Fix duplicate event subscriptions on retry - #87
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
subscribeToBeaconEvents subscribed topics one at a time and gave up on the first failure, leaving earlier topics subscribed. The retry loop then resubscribed the whole list every two seconds, so topics before a bad one built up duplicate live subscriptions forever while topics after it never subscribed at all. Now already-subscribed topics are tracked and skipped on retry, and a topic that fails is logged and skipped instead of aborting the rest of the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscribeToBeaconEvents subscribed topics one at a time and gave up on the first failure, leaving earlier topics subscribed. The retry loop then resubscribed the whole list every two seconds, so topics before a bad one built up duplicate live subscriptions forever (each one an independently reconnecting stream, so handlers fire once per duplicate) while topics after it never subscribed at all.
Fix tracks already-subscribed topics and skips them on retry, and logs and skips a topic that fails instead of aborting the rest of the list.
Test plan